Added RateLimitedSampler #41925
Closed
Added RateLimitedSampler #41925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rads-1996
requested review from
lzchen,
jeremydvoss,
hectorhdzg,
Karlie-777,
MSNev and
JacksonWeber
as code owners
github-actions
bot
added
Monitor - Distro
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a rate-limited sampler alongside the existing fixed-percentage sampler in the Azure Monitor OpenTelemetry SDK. Key changes include:
- Introducing new constants and environment variable handling for RATE_LIMITED_SAMPLER and sampling traces per second.
- Updating
_get_configurations,_configure, and SDK constants to select between rate-limited and fixed-percentage samplers. - Implementing
RateLimitedSampler, utility functions (_get_djb2_sample_score,_round_down_to_nearest), and comprehensive tests for sampling behavior.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/utils/test_configurations.py | Added tests for rate-limited and fixed-percentage sampler env var scenarios |
| _constants.py (SDK) | Defined RATE_LIMITED_SAMPLER, FIXED_PERCENTAGE_SAMPLER, and SAMPLING_TRACES_PER_SECOND_ARG |
| configurations.py | Enhanced _default_sampling_ratio to branch on sampler type and set appropriate configuration |
| _configure.py | Updated setup to instantiate RateLimitedSampler when traces-per-second is set |
| exporter/_utils.py | Added _get_djb2_sample_score and improved rounding logic |
| _rate_limited_sampling.py | Implemented RateLimitedSamplingPercentage and RateLimitedSampler |
| exporter/_constants.py | Defined hash and integer bounds for sampling utilities |
sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_configure.py
Outdated
Show resolved
Hide resolved
sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_utils/configurations.py
Show resolved
Hide resolved
sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_utils/configurations.py
Show resolved
Hide resolved
sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_utils/configurations.py
Show resolved
Hide resolved
rads-1996
force-pushed
the
rate-limited-sampler
branch
from
360c7da to
7183758
Compare
|
The existing sampler - |
|
A fresh one created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for RateLimitedSampler, inspired by Java Application Insights sampler
https://github.com/microsoft/ApplicationInsights-Java/blob/main/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/sampling/RateLimitedSamplingPercentage.java
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines